Update lean toolchain after lake update
#354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
Project: Update Dependency
command so that it updates the toolchain after runninglake update
. This was prompted by the introduction of a post-update hook in leanprover-community/mathlib4#8243 that automatically updates the toolchain.With the post-update hook and asking to update the toolchain before running
lake update
, a user decision of "Do not update the toolchain" would be ignored for projects downstream of Mathlib, as the post-update hook will update the toolchain regardless of the user choice. Asking to update the toolchain (if it changed) afterlake update
ensures users do not see a misleading dialog.One caveat is that this means that we will now run
lake update
with the Lean version of the project itself, not the Lean version of its dependency.Another change induced by switching the order of operations is that we can now read the toolchain from
lake-packages
instead of fetching it fromraw.githubusercontent.com
.